Repository navigation
Updates 2/3: the Inbox's Update button, Update now, What's new - #1833
Merged
Merged
Conversation
backnotprop
force-pushed
the
feat/updates-check
branch
from
October 11, 2026 00:05
9edd09d to
33c64fd
Compare
backnotprop
force-pushed
the
feat/updates-inbox
branch
from
October 11, 2026 00:08
4d723ff to
82c9022
Compare
backnotprop
force-pushed
the
feat/updates-inbox
branch
2 times, most recently
from
October 11, 2026 00:58
98822e6 to
832ade3
Compare
…, What's new The sidebar shows one filled Update button above Settings as soon as a newer release is AVAILABLE (the shared daily check, which the long-lived Inbox also runs), then Updating, Ready (the existing restart-to-update signal), and a neutral Update failed for an install the person started. The update dialog has Update now in the first step (POST /api/inbox/update: the same install wrapper as auto-update, once, under update.lock), Remind me tomorrow (a server-side 24h snooze), and an Install new versions automatically checkbox that writes autoUpdate. The Inbox restarts itself once the update it started is in, asking first when a reply is unsent. What's new is a page with the release notes; Settings gains About (Check now and both switches).
…owser proof, no real install script in tests - inbox-tailscale.test.ts: every update route (Update now, snooze, Check now, the facts, What's new, the update switches) answers 403 local_only through the tailnet and launches or writes nothing. - inbox-updates.test.ts: another serverSession gets 409 session_mismatch. - tests/e2e/inbox-updates.spec.ts: a release-version Inbox with a seeded update-state.json shows Update, the dialog, and Update now runs a fake install script once for that version. - Test preloads and the e2e world point PLANNOTATOR_INSTALL_SCRIPT_URL at a closed loopback port. - test.yml keeps main's links.test.tsx beside updates.test.tsx; docs name the Inbox as a caller of the check.
backnotprop
force-pushed
the
feat/updates-inbox
branch
from
October 11, 2026 01:23
832ade3 to
09600bd
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 3 of the owner-approved update notices (design
.product/approved/plannotator-updates/). Stacked on #1830 (basefeat/updates-check); review that first.What it does
Server (
packages/server/inbox-updates.ts, wired intopackages/server/inbox.ts):updateon health / list model / SSEstatusgrows to{ available: true, state, version, current, action, releaseUrl, publishedAt? }(InboxUpdatein core;available+versionkeep the old shape).available(a newer release from the shared daily check, nothing installed yet; shown at once, owner's answer 2),updating(update.lockheld),ready(the existing binary-on-disk probe),failed(an install the person started exited non-zero; background failures stay out of the sidebar).PLANNOTATOR_UPDATE_CHECKis off). While updating, it probes the binary every 2 s.GET /api/inbox/update(dialog facts: flags, command, open sessions, notes summary, failure),POST /api/inbox/update(Update now:startManualUpdate, the same wrapper as auto-update; a second press →409 update_locked),POST /api/inbox/update/snooze(Remind me tomorrow, server-side, every tab agrees),POST /api/inbox/update/check(Check now),GET /api/inbox/whats-new?version=.POST /api/inbox/settingstakesupdate_check/auto_update. Same-origin +serverSessionguards; none answer through the tailnet.updated: the first run on a newer version than the Inbox ran before shows "What's new in X" for that run.Window (
packages/inbox/components/Updates.tsx):.ib-restartrow: tooltip, accessible name, disabled spinner for Updating/Restarting, neutral outline for Failed. No motion besides the spinner (stopped under reduced motion).autoUpdate, owner's answer 6), Remind me tomorrow. An unmanaged binary gets the command instead.#whats-new=X, read-only Viewer, skipped-release highlights); Settings → About (version, last check, Check now, both switches).Tests
packages/server/inbox-updates.test.ts(real Inbox server, stubbed fetch and installer): the button appears on available from one check across many ticks; off via config and env (no request); dev build; unmanaged →copy; Update now runs once, second press locked; cross-site refused; failed only for person-started; snooze; the checkbox route writesautoUpdate; What's new + skipped; "just updated"; the pure state rules.packages/inbox/updates.test.tsx(DOM): button per state, dialog contents, checkbox reports the change and is locked by env, unmanaged dialog, failed dialog.tests/e2e/inbox.spec.tsrestart test moved to the new button. Test preloads and the e2e world pointPLANNOTATOR_UPDATE_API_URLat a closed loopback port, so no test reaches GitHub.Screenshots (Playwright against the built window) are in the series summary.